Skip to content

Reland integration_test NNBD#75074

Merged
dnfield merged 3 commits intoflutter:masterfrom
dnfield:nnbd_fuchsia
Feb 1, 2021
Merged

Reland integration_test NNBD#75074
dnfield merged 3 commits intoflutter:masterfrom
dnfield:nnbd_fuchsia

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 30, 2021 •
edited
Loading

Fixes #71379 again

Relands #74922 (reverted in #75030)

I think we just had a bad merge or something - tests should all be passing now. Relevant changes in 949b484

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 30, 2021
@google-cla google-cla bot added the cla: yes label Jan 30, 2021
jiahaog
jiahaog approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@jiahaog jiahaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor Author

dnfield commented Feb 1, 2021

Google testing is expected to fail since it needs a g3fix.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 1, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield merged commit d309254 into flutter:master Feb 1, 2021
@dnfield dnfield deleted the nnbd_fuchsia branch February 1, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@jiahaog jiahaog jiahaog approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[integration_test] Needs null safety migration

4 participants

@dnfield @fluttergithubbot @goderbauer @jiahaog