Always run the flutter tool in checked mode.#7655
Closed
Hixie wants to merge 1 commit intoflutter:masterfrom
Closed
Always run the flutter tool in checked mode.#7655Hixie wants to merge 1 commit intoflutter:masterfrom
Hixie wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
|
Maybe we should do this on Travis? It seems wrong to run in checked mode in production. |
Contributor
Author
|
I don't think we should keep this on forever, but we are regularly failing to catch problems because of not using checked mode around the team. Case in point, Travis failed this. Looking into it now... |
Contributor
Author
|
Fixes #4807 |
Contributor
Author
|
Blocked on dart-lang/sdk#28519 |
Contributor
Author
|
Closing until dart-lang/sdk#28519 is fixed and rolled in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.