Skip to content

Revert "fixes TextInputFormatter gets wrong old value of a selection …#76627

Merged
chunhtai merged 1 commit intoflutter:masterfrom
chunhtai:issues/75502-revert
Feb 23, 2021
Merged

Revert "fixes TextInputFormatter gets wrong old value of a selection …#76627
chunhtai merged 1 commit intoflutter:masterfrom
chunhtai:issues/75502-revert

Conversation

@chunhtai
Copy link
Contributor

…(#75541)"

This reverts commit a46139a.

change cause internal test failure

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 23, 2021
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@chunhtai chunhtai merged commit b513951 into flutter:master Feb 23, 2021
@justinmc
Copy link
Contributor

@chunhtai FYI This will have conflicts with my PR #76327 if/when you un-revert it. It's an easy fix though, let me know if you need help with the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants