Skip to content

Reland "fixes TextInputFormatter gets wrong old value of a selection"#76653

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
chunhtai:issues/75502-reland
Mar 2, 2021
Merged

Reland "fixes TextInputFormatter gets wrong old value of a selection"#76653
fluttergithubbot merged 3 commits intoflutter:masterfrom
chunhtai:issues/75502-reland

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Feb 23, 2021 •
edited
Loading

The previous changes was revert due to internal tests failure

Besides expected scuba failure, there is one failure whose root cause is actually #76634

Once that issue is fixed, this PR is ready to be relanded. Nothing has changed from previous PR
fixes #75502

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 23, 2021
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@chunhtai chunhtai requested a review from justinmc February 23, 2021 23:57
justinmc
justinmc approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Looks like #76634 is merged now.

You've also got merge conflicts due to my #76327 being merged just now as I mentioned.

@chunhtai chunhtai force-pushed the issues/75502-reland branch 2 times, most recently from 2940d7c to 8dbc871 Compare March 1, 2021 23:06
@chunhtai chunhtai force-pushed the issues/75502-reland branch from 8dbc871 to 2ac512b Compare March 1, 2021 23:08
@fluttergithubbot fluttergithubbot merged commit b0d4d44 into flutter:master Mar 2, 2021
lukepighetti added a commit to lukepighetti/flutter that referenced this pull request Mar 17, 2021
@lukepighetti
Revert "Reland "fixes TextInputFormatter gets wrong old value of a se…
505be33 
…lection" (flutter#76653)"

Related issue (flutter#77855)

This reverts commit b0d4d44.
@lukepighetti lukepighetti mentioned this pull request Mar 17, 2021
Closed
8 tasks
@justinmc justinmc mentioned this pull request Jul 2, 2021
Merged
@Piinks Piinks mentioned this pull request Feb 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextInputFormatter gets wrong old value of a selection

3 participants

@chunhtai @justinmc @fluttergithubbot