ShaderMask on web for CupertinoContextMenu#77864
Merged
justinmc merged 3 commits intoflutter:masterfrom Mar 11, 2021
Merged
Conversation
flutter-dashboard
bot
added
f: cupertino
LongCatIsLooong
approved these changes
Mar 11, 2021
| // conditional and just check for ShaderMask. | ||
| // https://github.com/flutter/flutter/issues/52967. | ||
| expect(find.byType(ShaderMask), kIsWeb ? findsNothing : findsOneWidget); | ||
| expect(find.byType(ShaderMask), findsOneWidget); |
Contributor
There was a problem hiding this comment.
The test is getting skipped when isBrowser is true. Is the skip still needed?
Contributor
Author
There was a problem hiding this comment.
Ah good catch, there are a bunch of skipped tests that reference #44152. They seem to pass now, so I will unskip all of them.
|
Gold has detected about 2 untriaged digest(s) on patchset 3. |
ferhatb
reviewed
Mar 12, 2021
Contributor
ferhatb
left a comment
ferhatb
left a comment
There was a problem hiding this comment.
LGTM. Thank you for unskipping tests too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm told that web now supports ShaderMask, so we can remove this workaround that was put into CupertinoContextMenu to simplify it so it didn't need ShaderMask on web.
Also unskips ShaderMask tests on web.
Closes #52967