Bump Dart SDK to 1.22.0-dev.10.3#7791
Merged
goderbauer merged 1 commit intoflutter:masterfrom Feb 2, 2017
Merged
Conversation
Member
Author
|
/cc @leafpetersen @pq |
Hixie
reviewed
Feb 1, 2017
examples/stocks/lib/stock_data.dart
Outdated
Contributor
There was a problem hiding this comment.
This shouldn't be needed. return without a value should just return null, no? We rely on this all over the place.
Member
Author
There was a problem hiding this comment.
The analyzer is complaining about it:
[warning] Missing return value after 'return'. (/usr/local/google/home/goderbauer/dev/flutter/examples/stocks/lib/stock_data.dart, line 79, col 9)
Contributor
There was a problem hiding this comment.
we talked about it and i am convinced we can work with this change
Hixie
reviewed
Feb 1, 2017
Contributor
There was a problem hiding this comment.
nit: the syntax is // TODO(username): message url, you're missing the colon.
Hixie
reviewed
Feb 1, 2017
Contributor
There was a problem hiding this comment.
this is over-indented by 2 (should line up with the onError)
Contributor
|
Once you get it past @Hixie, works for me. 👍 Thanks for picking this up! |
goderbauer
force-pushed
the
dartSdkBump
branch
from
6f9ef0c to
758db3c
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for engine roll (#7777).