Skip to content

Protect the hasScopedWillPopCallback ModalRoute method#7832

Merged
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:protect_has_scoped_will_pop_callback
Feb 2, 2017
Merged

Protect the hasScopedWillPopCallback ModalRoute method#7832
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:protect_has_scoped_will_pop_callback

Conversation

@HansMuller
Copy link
Contributor

Fixes #7826

@abarth
Copy link
Contributor

abarth commented Feb 2, 2017

LGTM

@HansMuller HansMuller merged commit e366c96 into flutter:master Feb 2, 2017
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

route.hasScopedWillPopCallback is a foot gun

3 participants