Skip to content

Update cluster.#78678

Merged
godofredoc merged 6 commits intoflutter:masterfrom
godofredoc:update_cluster
Mar 23, 2021
Merged

Update cluster.#78678
godofredoc merged 6 commits intoflutter:masterfrom
godofredoc:update_cluster

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 20, 2021 •
edited
Loading

We are reusing the engine kubernetes pool which was setup for compiling. Framework is using a several many different CPU/Memory configs that are generating multiple errors in Cirrus tasks in all the different repositories,

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 20, 2021
@jmagman
Copy link
Member

jmagman commented Mar 23, 2021 

▌20:32:14▐ RUNNING: cd .; bin/flutter update-packages --verify-only
   Woah! You appear to be trying to run flutter as root.
   We strongly recommend running the flutter tool without superuser privileges.

flutter/bin/internal/shared.sh

Lines 193 to 195 in 357dcc9

# Test if running as superuser – but don't warn if running within Docker
if [[ "$EUID" == "0" && ! -f /.dockerenv ]]; then
>&2 echo " Woah! You appear to be trying to run flutter as root."

See #10535.
Does /.dockerenv exist? Do we need to run as root?

@jmagman
Copy link
Member

jmagman commented Mar 23, 2021

That superuser warning isn't just happening on this PR, I see the same warning in #78757 https://cirrus-ci.com/task/5785665553039360

This was referenced Mar 23, 2021
Merged
Merged
Merged
This was referenced Mar 23, 2021
Merged
Merged
@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Mar 23, 2021
@godofredoc godofredoc requested a review from jmagman March 23, 2021 16:22
jmagman
jmagman approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This was referenced Mar 23, 2021
Merged
Merged
Merged
Merged
@godofredoc godofredoc merged commit c2d12ea into flutter:master Mar 23, 2021
@godofredoc godofredoc deleted the update_cluster branch March 23, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @goderbauer