Merged
Conversation
Closed
Contributor
Author
Hixie
reviewed
Feb 4, 2017
Contributor
There was a problem hiding this comment.
looks like we got the alignment of the parentheses off a bit here
Hixie
reviewed
Feb 4, 2017
Contributor
There was a problem hiding this comment.
s/=/:/ unless you have some convention i'm not aware of :-)
Contributor
Author
There was a problem hiding this comment.
Ugg. They started out as = and I forgot to convert that one.
Hixie
reviewed
Feb 4, 2017
Contributor
|
Thanks. |
abarth
force-pushed
the
custom_scroll_view
branch
from
2634bad to
7246211
Compare
Also, use CustomScrollView in Shrine and fix a bug with one-line grids not painting properly due to their reporiting zero paintExtent.
abarth
force-pushed
the
custom_scroll_view
branch
from
7246211 to
99df401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, use CustomScrollView in Shrine and fix a bug with one-line grids
not painting properly due to their reporiting zero paintExtent.