Merged
Conversation
This reverts commit 2c2c8a7.
flutter-dashboard
bot
added
the
framework
justinmc
approved these changes
Mar 23, 2021
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM. There is a failure here in web_integration_tests, but it seems to be unrelated.
Though, it doesn't seem to me like this PR should have caused these failures. I'm investigating.
Contributor
Author
|
Merge on red because this is a clean revert of a relative new PR not too far from ToT. |
Contributor
|
Thanks @renyou for unblocking the tree :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #77414 This PR breaks Google internal tests.