Refactor text editing test APIs by Hixie · Pull Request #79061 · flutter/flutter

Hixie · 2021-03-25T17:30:28Z

...and remove a legacy TODO whose referenced issue (#51885) is now closed.

To actually fix this required some refactoring of the text editing test APIs.

See #77454 for original discussion.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie · 2021-03-31T21:19:55Z

Ok I think the new test failures are because the code that called enterText was previously relying on the fact that we always registered the testTextInput even when we didn't want to, and for some reason we assert that we have done so. I'll remove the asserts.

Hixie · 2021-04-02T00:45:48Z

New problem: the client ID doesn't match what the text field is expecting, so the text field ignores it...

Hixie · 2021-04-02T20:39:49Z

cc @LongCatIsLooong @justinmc

Hixie · 2021-04-02T20:40:27Z

cc @dnfield @goderbauer in case you're interested in seeing the differences since the last version

justinmc

LGTM 👍

justinmc · 2021-04-02T22:23:48Z

packages/flutter_test/lib/src/binding.dart

Sounds reasonable.

justinmc · 2021-04-02T22:34:41Z

packages/flutter_test/lib/src/test_text_input.dart

Should the selection be set to the end of the text?

@LongCatIsLooong is doing that in #79506 but it got reverted due to google3 breakage.

Ah I thought that sounded familiar 👍

justinmc · 2021-04-02T22:41:06Z

packages/flutter_test/test/bindings_test.dart

Nit: Alternatively you could use a group and do the incrementing in a setUp. Fine either way though.

I still live in hope that we can destroy group and setUp and so on...

(i think it's way more readable if you just have the code running bit by bit rather than having to know what order setUp/group/etc run in, and what the implications of all those methods are, Zones, how it impacts futures, etc)

Ah I hadn't realized anyone was anti-group/setUp, I've been using them just because they were there. I'll think about this next time I encounter it.

justinmc · 2021-04-02T22:43:39Z

packages/flutter/lib/src/services/text_input.dart

I still can't think of a better way than this magic -1 thing. It doesn't seem too bad.

Hixie · 2021-04-02T22:55:36Z

Thanks for the review! I've marked this so it'll land on green (had to fix a merge conflict due to the revert of @LongCatIsLooong's PR).

fluttergithubbot · 2021-04-02T23:59:03Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

Hixie · 2021-04-03T00:55:37Z

Updated again, I conflicted with @LongCatIsLooong's revert of his revert. :-)
Hopefully it lands this time. :-)

This reverts commit b070ed3.

...and remove a legacy TODO whose referenced issue (flutter#51885) is now closed. To actually fix this required some refactoring of the text editing test APIs. See flutter#77454 and flutter#79061 for earlier discussions. This was last reverted in flutter#79559.

* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 25, 2021

google-cla bot added the cla: yes label Mar 25, 2021

Hixie mentioned this pull request Mar 25, 2021

Refactor text editing test APIs #78637

Closed

8 tasks

Hixie force-pushed the reland_clean_text_input branch 2 times, most recently from 8da36bc to 2ffd137 Compare March 31, 2021 22:35

Hixie force-pushed the reland_clean_text_input branch 2 times, most recently from 0e5f3eb to 1a14886 Compare April 2, 2021 19:40

Hixie marked this pull request as ready for review April 2, 2021 20:39

justinmc approved these changes Apr 2, 2021

View reviewed changes

Hixie force-pushed the reland_clean_text_input branch from 1a14886 to 87b2529 Compare April 2, 2021 22:54

Hixie added the waiting for tree to go green label Apr 2, 2021

fluttergithubbot removed the waiting for tree to go green label Apr 2, 2021

Fix a legacy TODO (flutter#77454)

961a963

Hixie force-pushed the reland_clean_text_input branch from 87b2529 to 961a963 Compare April 3, 2021 00:44

Hixie added the waiting for tree to go green label Apr 3, 2021

fluttergithubbot merged commit b070ed3 into flutter:master Apr 3, 2021

Hixie mentioned this pull request Apr 5, 2021

Migrate to ChannelBuffers.push #76288

Merged

8 tasks

justinmc added a commit that referenced this pull request Apr 7, 2021

Revert "Fix a legacy TODO (#77454) (#79061)"

9c3cbed

This reverts commit b070ed3.

justinmc mentioned this pull request Apr 7, 2021

Unblock roll by reverting #79061 #79959

Merged

renyou pushed a commit that referenced this pull request Apr 7, 2021

Revert "Fix a legacy TODO (#77454) (#79061)" (#79959)

0efb28d

This reverts commit b070ed3.

Hixie mentioned this pull request Apr 8, 2021

Refactor text editing test APIs (Mark III) #80003

Merged

8 tasks

This was referenced May 2, 2021

Migrate to ChannelBuffers.push #81235

Merged

Migrate to ChannelBuffers.push #82057

Merged

Hixie mentioned this pull request May 14, 2021

Migrate to ChannelBuffers.push #82564

Merged

8 tasks

darshankawar mentioned this pull request Oct 6, 2021

[Regression][2.5]: Integration tests fail if wrapped with Semantics widgets (eg: MergeSemantics). #91326

Closed

Conversation

Hixie commented Mar 25, 2021

Pre-launch Checklist

Uh oh!

Hixie commented Mar 31, 2021

Uh oh!

Hixie commented Apr 2, 2021

Uh oh!

Hixie commented Apr 2, 2021

Uh oh!

Hixie commented Apr 2, 2021

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hixie commented Apr 2, 2021

Uh oh!

fluttergithubbot commented Apr 2, 2021

Uh oh!

Hixie commented Apr 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hixie commented Apr 3, 2021 •

edited

Loading