Skip to content

Clarify documentation for DragAnchorStrategy.#79160

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:DragAnchor
Apr 5, 2021
Merged

Clarify documentation for DragAnchorStrategy.#79160
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:DragAnchor

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Mar 26, 2021 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 26, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 26, 2021
@google-cla google-cla bot added the cla: yes label Mar 26, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Mar 26, 2021

cc @prosac @chunhtai

chunhtai
chunhtai approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except test failure

@Hixie
Copy link
Contributor Author

Hixie commented Mar 29, 2021

Weird, the same API in LongPressDraggable wasn't deprecated. Was that intentional?

I've updated the PR to deprecate the API there too, and updated the example accordingly.

@chunhtai
Copy link
Contributor

chunhtai commented Mar 29, 2021

Weird, the same API in LongPressDraggable wasn't deprecated. Was that intentional?

I've updated the PR to deprecate the API there too, and updated the example accordingly.

The intention is to do that in a separate pr. I wonder if @prosac has one in progress? Since you already include in this PR, I think we should just merge this

chunhtai
chunhtai reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a test for LongPressDraggable

packages/flutter/lib/src/widgets/drag_target.dart Outdated
Copy link
Contributor

@chunhtai chunhtai Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need a test for this. Since Draggable already has test coverage, We can probably just create the LongPressDraggable with dragAnchorStrategy and make sure the same callback is passed into Draggable

@Hixie
Copy link
Contributor Author

Hixie commented Mar 29, 2021

Is there more to it than I think? The change to do that was basically 5 lines as far as I can tell.

@chunhtai
Copy link
Contributor

chunhtai commented Mar 29, 2021

Is there more to it than I think? The change to do that was basically 5 lines as far as I can tell.

No I think this is it.

@chunhtai chunhtai mentioned this pull request Apr 2, 2021
Merged
13 tasks
@chunhtai
Copy link
Contributor

chunhtai commented Apr 2, 2021

Hi @Hixie are you still working on this PR?

@Hixie
Copy link
Contributor Author

Hixie commented Apr 2, 2021

Yeah, though feel free to take it if you want to run with it.

@Hixie
Copy link
Contributor Author

Hixie commented Apr 3, 2021

Added a test as suggested.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 3, 2021
chunhtai
chunhtai approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the test.

@fluttergithubbot fluttergithubbot merged commit 90c0e3e into flutter:master Apr 5, 2021
@prosac
Copy link

prosac commented Apr 7, 2021

hi! i during the weekend i planned to implement the change for LongPressDraggable but ended up making the following suggestion-PR: #79784

@prosac
Copy link

prosac commented Apr 7, 2021 •
edited
Loading

i will continue implementing the DragAnchorStrategy changes when I have my next after work coding spree ;-). I guess tomorrow or sunday.

@prosac
Copy link

prosac commented Apr 8, 2021

wow. was too tired to check out the code yesterday. all done 🥇 . thank you @Hixie !

@Hixie
Copy link
Contributor Author

Hixie commented Apr 8, 2021

you're welcome :-)

@Hixie Hixie deleted the DragAnchor branch April 8, 2021 19:29
This was referenced Apr 16, 2021
Closed
Merged
@Piinks Piinks mentioned this pull request Sep 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @chunhtai @prosac @fluttergithubbot