Make ensureVisible work with sliver-based viewports#7920
Merged
abarth merged 1 commit intoflutter:masterfrom Feb 7, 2017
Merged
Make ensureVisible work with sliver-based viewports#7920abarth merged 1 commit intoflutter:masterfrom
abarth merged 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
maybe add TODO here mentioning that we should support other coordinate systems more generically
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
assert that child.parent==this
Contributor
|
|
There appears to be an issue with children before the center widget. I've filled a bug about that issue and will follow up in a later patch.
abarth
force-pushed
the
ensure_visible_works
branch
from
9c2344e to
1e9552b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be an issue with children before the center widget.
I've filled a bug about that issue and will follow up in a later patch.