Additional TabController, DefaultTabController docs#7930
Merged
HansMuller merged 3 commits intoflutter:masterfrom Feb 7, 2017
Merged
Additional TabController, DefaultTabController docs#7930HansMuller merged 3 commits intoflutter:masterfrom
HansMuller merged 3 commits intoflutter:masterfrom
Conversation
abarth
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
Do you need to dispose the tab controller in dispose ?
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for catching that!
Contributor
|
|
HansMuller
force-pushed
the
tab_controller_docs
branch
from
0894528 to
60aa9fd
Compare
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
nit: I would avoid "and/or". Just say "or".
Hixie
reviewed
Feb 7, 2017
Hixie
reviewed
Feb 7, 2017
HansMuller
force-pushed
the
tab_controller_docs
branch
from
60aa9fd to
26a8cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7926