enterText to move the caret to the end#79506
enterText to move the caret to the end#79506fluttergithubbot merged 6 commits intoflutter:masterfrom
enterText to move the caret to the end#79506Conversation
flutter-dashboard
bot
added
a: tests
|
Dependent on #79489 |
|
Gold has detected about 3 untriaged digest(s) on patchset 3. |
LongCatIsLooong
changed the title
enterText to have trailing caretenterText to move the caret to the end
| ); | ||
|
|
||
| testWidgets('cursor layout has correct width', (WidgetTester tester) async { | ||
| final TextEditingController controller = TextEditingController.fromValue( |
There was a problem hiding this comment.
These golden tests were drawing the caret for position -1.
|
If you can land this without breaking the world then I am supportive, LGTM. Amusingly it'll conflict with two separate PRs I'm writing right now but luckily it won't do so in a complicated way and those two PRs are already conflicting with each other so whatever. ;-) |
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
If this requires google3 changes then we should do a migration guide.
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
I feel like I have run into this before, good call.
| /// Give the text input widget specified by [finder] the focus and | ||
| /// enter [text] as if it been provided by the onscreen keyboard. | ||
| /// Give the text input widget specified by [finder] the focus, replace its | ||
| /// content with [text], as if it been provided by the onscreen keyboard. |
There was a problem hiding this comment.
Nit:
- focus, replace its content with [text], as if it been
+ focus and replace its content with [text], as if it had been
…verted in (flutter#79654) This reverts commit bf6e38d.
5 participants
Fixes #79494. Running TGP to see how breaking this is. result(internal link).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.