Remove RunLoop from Windows template#79969
Merged
cbracken merged 1 commit intoflutter:masterfrom Apr 27, 2021
Merged
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
|
@cbracken can this be merged? if so please add the "waiting for tree" tag on it so it can be merged |
rydmike
added a commit
to rydmike/flex_color_picker
that referenced
this pull request
Apr 16, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
rydmike
added a commit
to rydmike/flex_color_scheme
that referenced
this pull request
Apr 16, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
Contributor
|
Friendly ping @cbracken can this be landed? |
rydmike
added a commit
to rydmike/flex_color_picker
that referenced
this pull request
Jun 11, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
rydmike
added a commit
to rydmike/flex_color_scheme
that referenced
this pull request
Jun 24, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
rydmike
added a commit
to rydmike/flex_color_scheme
that referenced
this pull request
Nov 13, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
rydmike
added a commit
to rydmike/flex_color_scheme
that referenced
this pull request
Nov 13, 2021
This new runloop gets rid of extra CPU load on Windows, but may require a version that is not available on all channels yet. Refer to issue: flutter/flutter#79195 flutter/engine#24232 This should fix it at some point: flutter/flutter#79969
This was referenced Mar 29, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
RunLoopclass from Windows template and changes the message pump to idiomatic Get/Translate/DispatchMessage loop.After flutter/engine#24232 it is no longer necessary to call
FlutterDesktopEngineProcessMessages.List which issues are fixed by this PR. You must list at least one issue.
Fixes #78517, but only for newly created projects.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.