Skip to content

Remove a dynamic that is no longer necessary (and the TODO for it)#80294

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
gspencergoog:remove_todo
Apr 12, 2021
Merged

Remove a dynamic that is no longer necessary (and the TODO for it)#80294
fluttergithubbot merged 1 commit intoflutter:masterfrom
gspencergoog:remove_todo

Conversation

@gspencergoog
Copy link
Contributor

This is a lingering dynamic usage left over from the transition to handling key events asynchronously.

Removed the dynamic reference and replaced it with the actual type (KeyEventResult) expected.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 12, 2021
@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@gspencergoog gspencergoog requested a review from dkwingsmt April 12, 2021 17:41
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 12ec7dc into flutter:master Apr 12, 2021
jmagman added a commit that referenced this pull request Apr 13, 2021
jmagman added a commit that referenced this pull request Apr 13, 2021
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants