fix a NestedScrollView's ScrollPosition access bug#80573
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Apr 26, 2021
Merged
fix a NestedScrollView's ScrollPosition access bug#80573fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
Member
Author
|
@chunhtai hi, please take a look at this.: ) |
chunhtai
reviewed
Apr 21, 2021
| @override | ||
| void detach(ScrollPosition position) { | ||
| assert(position is _NestedScrollPosition); | ||
| (position as _NestedScrollPosition).detachFromParent(); |
Contributor
There was a problem hiding this comment.
The parent is set in attach method, We should reset the parent directly something like
(position as _NestedScrollPosition).setParent(null);
Member
Author
There was a problem hiding this comment.
Yes, you are very right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74372
Also, resolve a StackOverflow question been asked a long time ago:
https://stackoverflow.com/questions/53824944/flutter-exception-scrollcontroller-attached-to-multiple-scroll-views
Detach the position in the microtask, because there will be a delay and cause this bug.
ScrollableState._updatePosition