Skip to content

Update ReorderableListView docs to avoid confusion between desktop and mobile#80576

Closed
idkq wants to merge 0 commit intoflutter:masterfrom
idkq:patch-1
Closed

Update ReorderableListView docs to avoid confusion between desktop and mobile#80576
idkq wants to merge 0 commit intoflutter:masterfrom
idkq:patch-1

Conversation

@idkq
Copy link

@idkq idkq commented Apr 16, 2021

Prevents this #80553

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 16, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @idkq thanks for the contribution!

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Jun 10, 2021
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I am reaching out to @Hixie for test exemption. :)

Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idkq thanks for the contribution. Let's go with @Piinks suggested wording and then we can land this.

Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I was ninja'd. LGTM too.

@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/80576

@darrenaustin darrenaustin changed the title Avoids confusion between desktop and mobile Update ReorderableListView docs to avoid confusion between desktop and mobile Jun 10, 2021
@Hixie
Copy link
Contributor

Hixie commented Jun 10, 2021

test-exempt: only affects comments

@Piinks
Copy link
Contributor

Piinks commented Jun 10, 2021

Hey @idkq can you rebase this with the latest from master? I think the age of this PR is causing some issues with CI.

@idkq
Copy link
Author

idkq commented Jun 11, 2021

@Piinks I might need to open a new PR as this did not work - not sure what is going on

@darrenaustin
Copy link
Contributor

You should just be able to rebase your change on top of the changes from master with something like:

git pull --rebase upstream master 
git push --force origin idkq:patch-1

But if you have already tried that and it didn't work then go ahead and open a new PR with your changes.

idkq added a commit to idkq/flutter that referenced this pull request Jul 20, 2021
idkq added a commit to idkq/flutter that referenced this pull request Jul 20, 2021
…d mobile (v2)

Prevents this flutter#80553

More info here flutter#80576

Comments only change. These changes were pre-approved on the pull 80576 but not pushed.
@idkq
Copy link
Author

idkq commented Jul 20, 2021

Apologies for the delay. @darrenaustin I tried that but did not work. I opened a new one here #86737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants