Update ReorderableListView docs to avoid confusion between desktop and mobile#80576
Update ReorderableListView docs to avoid confusion between desktop and mobile#80576idkq wants to merge 0 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 3 new digest(s) on patchset 3. |
|
test-exempt: only affects comments |
|
Hey @idkq can you rebase this with the latest from master? I think the age of this PR is causing some issues with CI. |
|
@Piinks I might need to open a new PR as this did not work - not sure what is going on |
|
You should just be able to rebase your change on top of the changes from master with something like: git pull --rebase upstream master
git push --force origin idkq:patch-1But if you have already tried that and it didn't work then go ahead and open a new PR with your changes. |
…d mobile (v2) Prevents this flutter#80553 More info here flutter#80576 Comments only change. These changes were pre-approved on the pull 80576 but not pushed.
|
Apologies for the delay. @darrenaustin I tried that but did not work. I opened a new one here #86737 |
Prevents this #80553