Replace some dynamic to Object? type#80772
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
f: material design
|
@Hixie hi, can this test-exempt? |
shihaohong
left a comment
shihaohong
left a comment
There was a problem hiding this comment.
The PR looks good, minus one analyzer failure.
I'm wondering if it really isn't possible to test for this change, since it'd be quite easy to just start using dynamic everywhere instead of Object? in the codebase in the future
| return casted.map<String?, List<Object>>((Object? key, Object? value) => MapEntry<String?, List<Object>>( | ||
| key as String?, | ||
| List<Object>.from(value as List<dynamic>, growable: true), | ||
| List<Object>.from(value as List<Object?>, growable: true), |
There was a problem hiding this comment.
This is causing the analyzer failure. I believe it's expecting a List<Object>, but you're giving it a List<Object?>
|
test-exempt: code refactor without semantic change |
…utter#80965) This reverts commit 12a2e68.
…81076 (#81155) * Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965) This reverts commit 12a2e68. * Add frontend_server_client to dependency allowlist (#80912) * Revert "[RenderEditable] Dont paint caret when selection is invalid (#79607)" (#81076) This reverts commit 0f8148e. * Convert AnimatedSize to a StatefulWidget (#80554) Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Jason Simmons <[email protected]>
4 participants
Replace some
dynamictoObject?type