Don't update Android SDK settings in build.gradle.#8089
Merged
jakobr-google merged 1 commit intoflutter:masterfrom Feb 14, 2017
Merged
Don't update Android SDK settings in build.gradle.#8089jakobr-google merged 1 commit intoflutter:masterfrom
jakobr-google merged 1 commit intoflutter:masterfrom
Conversation
Contributor
That was the rational, but it sounds like things will continue working w/o this change, and we won't be doing things like modifying the user's build.gradle as a side effect of running an app. lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of detecting the installed Android SDKs, and always updating the build.gradle file to use the latest (which might be a preview, or otherwise might not work), let's just use what the build.gradle file specifies.
I believe the main rationale behind always updating the SDK versions was to make the build Just Work with what's installed on the user's computer. However, if we just leave the version to what the user has set it to, Gradle will automatically download the specified SDK, if the user has accepted the licenses in SDK Manager. So things will still work, and the build will no longer depend on whatever SDKs you happened to have installed on your machine.
Fixes #5638.