Change --disable-dds to --no-dds to avoid double negatives#80900
Merged
Hixie merged 1 commit intoflutter:masterfrom Apr 23, 2021
Merged
Change --disable-dds to --no-dds to avoid double negatives#80900Hixie merged 1 commit intoflutter:masterfrom
Hixie merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Hixie
force-pushed
the
tool_arg_todos
branch
2 times, most recently
from
6f583bc to
affa5e8
Compare
zanderso
approved these changes
Apr 22, 2021
Member
|
Google testing test failures are related. |
Contributor
Author
|
Yeah I need to make sure we don't print the deprecation warning in |
Hixie
force-pushed
the
tool_arg_todos
branch
3 times, most recently
from
7edf3d5 to
25e3c9e
Compare
Contributor
Author
|
I've disabled the deprecation warning code for now. |
Hixie
force-pushed
the
tool_arg_todos
branch
2 times, most recently
from
dd9950e to
48d6749
Compare
Also, refactor internal code to do the same. See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, refactor internal code to do the same.
See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis
This is part of #76271
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.