Skip to content

migrate from jcenter to mavencentral#80908

Merged
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:migrate_from_j_center
Apr 22, 2021
Merged

migrate from jcenter to mavencentral#80908
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:migrate_from_j_center

Conversation

@jonahwilliams
Copy link
Contributor

Fixes #78338

Remove jcenter from the list of build.gradle repos and add mavenCentral.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 21, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Apr 21, 2021
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get all my TODOs from #78812 as well?

mavenCentral()
// TODO(jmagman): Remove with https://github.com/flutter/flutter/issues/78338
jcenter {
content {
includeModule("org.jetbrains.trove4j", "trove4j")
}
}

@jonahwilliams
Copy link
Contributor Author

Done

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! LGTM

@jonahwilliams jonahwilliams merged commit d9638d2 into flutter:master Apr 22, 2021
@jonahwilliams jonahwilliams deleted the migrate_from_j_center branch April 22, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move android project repositories away from JCenter

2 participants