Migrate to ChannelBuffers.push#81235
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom May 4, 2021
Merged
Conversation
flutter-dashboard
bot
added
a: accessibility
This was referenced Apr 26, 2021
Hixie
force-pushed
the
channel_buffers
branch
4 times, most recently
from
3e26b14 to
0282f0c
Compare
Contributor
Author
|
cc @goderbauer who reviewed the previous PRs that this lands; this does not have any code changes from the last two PRs that landed as far as I am aware. |
Contributor
|
RSLGTM (reland) |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
tvolkert
approved these changes
May 3, 2021
renyou
added a commit
that referenced
this pull request
May 4, 2021
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 14, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 21, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of #76288 which was reverted in #81226 due to google3 issues. Those should be solved by cl/370540746.
Also includes code to remove a legacy TODO whose referenced issue (#51885) is now closed.
See #77454, #79061, and #80003 for earlier discussions. This was last reverted in #81316.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.