[key_codegen] Remove webValues #81678
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
left a comment
There was a problem hiding this comment.
This doesn't appear to fix the problem with tab and enter: was that the intention, or is this just a precursor that you want me to merge with my change?
|
@gspencergoog The latter. You said there were desynchronization between gen_keycode and the final scripts. |
This PR removes
webValues. Web's logical mapping should mapwebNamesto logical key values, i.e.entry.value.This PR also includes other aesthetic changes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.