Skip to content

Migrate to ChannelBuffers.push#82057

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
Hixie:channel_buffers_5
May 13, 2021
Merged

Migrate to ChannelBuffers.push#82057
fluttergithubbot merged 4 commits intoflutter:masterfrom
Hixie:channel_buffers_5

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented May 7, 2021

  • Moves the handlePlatformMessage logic to using ChannelBuffers.
  • Moves the testing APIs from services library to flutter_test.
  • Refactors text editing test APIs.

This is a reland of #76288 and #78637.

See #77454, #79061, #80003, and #81235 for earlier discussions. This was last reverted in #81829.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 7, 2021
@google-cla google-cla bot added the cla: yes label May 7, 2021
@Hixie Hixie force-pushed the channel_buffers_5 branch 3 times, most recently from 3992174 to daf364a Compare May 12, 2021 21:15
@Hixie Hixie marked this pull request as ready for review May 12, 2021 21:16
stuartmorgan-g
stuartmorgan-g approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Hixie Hixie force-pushed the channel_buffers_5 branch from daf364a to 01a478d Compare May 13, 2021 20:16
@fluttergithubbot fluttergithubbot merged commit b86d5c0 into flutter:master May 13, 2021
@Hixie Hixie deleted the channel_buffers_5 branch May 13, 2021 22:35
Hixie added a commit that referenced this pull request May 14, 2021
@Hixie
Revert "Migrate to ChannelBuffers.push (#82057)"
af155c1 
This reverts commit b86d5c0.
@Hixie Hixie mentioned this pull request May 14, 2021
Merged
fluttergithubbot pushed a commit that referenced this pull request May 14, 2021
@Hixie
Revert "Migrate to ChannelBuffers.push (#82057)" (#82525)
2ae1e39
Hixie added a commit to Hixie/flutter that referenced this pull request May 14, 2021
@Hixie
Migrate to ChannelBuffers.push
f536a68 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
@Hixie Hixie mentioned this pull request May 14, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 21, 2021
@Hixie
Migrate to ChannelBuffers.push
a87a5f5 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @stuartmorgan-g @fluttergithubbot