Skip to content

Deprecated ThemeData buttonColor#82196

Merged
HansMuller merged 2 commits intoflutter:masterfrom
HansMuller:deprecate_button_color
May 10, 2021
Merged

Deprecated ThemeData buttonColor#82196
HansMuller merged 2 commits intoflutter:masterfrom
HansMuller:deprecate_button_color

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented May 10, 2021 •
edited
Loading

This property had been used to define the background fill color for the (now deprecated) RaisedButton class. It has not been used by Flutter since #59702 landed the new Button classes. At that time, RaisedButton was replaced by ElevatedButton, whose background and foreground colors can be specified with a ButtonStyle:

ElevatedButton(
  style: ElevatedButton.styleFrom(
    primary: Colors.red, // background
    onPrimary: Colors.white, // foreground
  ),
  onPressed: () { },
  child: Text('ElevatedButton with custom foreground/background'),
)

To change the background color of all ElevatedButtons in a MaterialApp:

MaterialApp(
  theme: ThemeData.from(colorScheme: ColorScheme.light()).copyWith(
    elevatedButtonTheme: ElevatedButtonThemeData(
      style: ElevatedButton.styleFrom(
         primary: Colors.red, // background
         onPrimary: Colors.white, // foreground
       ),
     ),
  ),
  // ...
)

More information about configuring ElevatedButton et al. can be found here: https://flutter.dev/docs/release/breaking-changes/buttons.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 10, 2021
@google-cla google-cla bot added the cla: yes label May 10, 2021
@HansMuller HansMuller requested a review from darrenaustin May 10, 2021 17:13
@HansMuller HansMuller force-pushed the deprecate_button_color branch from ed6b35d to 37402f4 Compare May 10, 2021 18:54
darrenaustin
darrenaustin approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

This was referenced May 10, 2021
Merged
Merged
@HansMuller HansMuller merged commit 1d8ab0f into flutter:master May 10, 2021
@guidezpl guidezpl mentioned this pull request Oct 13, 2021
Open
43 tasks
naturallymitchell pushed a commit to naturallymitchell/experiences that referenced this pull request May 4, 2022
[simple_browser] Fix build warnings
8f63834 
buttonColor is deprecated and unused:
flutter/flutter#82196

FIX: 77251
Change-Id: Ife5b43c87bfffbd0182902c33220335cc0227af2
Reviewed-on: https://fuchsia-review.googlesource.com/c/experiences/+/533961
Fuchsia-Auto-Submit: Alex Legg <[email protected]>
Reviewed-by: Sarah Pham <[email protected]>
Reviewed-by: Abdulla Kamar <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
github-actions bot pushed a commit to gnoliyil/fuchsia that referenced this pull request Oct 11, 2022
[simple_browser] Fix build warnings
ed96c02 
buttonColor is deprecated and unused:
flutter/flutter#82196

FIX: 77251
Change-Id: Ife5b43c87bfffbd0182902c33220335cc0227af2
Reviewed-on: https://fuchsia-review.googlesource.com/c/experiences/+/533961
Fuchsia-Auto-Submit: Alex Legg <[email protected]>
Reviewed-by: Sarah Pham <[email protected]>
Reviewed-by: Abdulla Kamar <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HansMuller @darrenaustin