Roll Engine to 44ba0c7c4bfd (5 revisions)#82310
Merged
cbracken merged 1 commit intoflutter:masterfrom May 12, 2021
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
engine
flutter/engine@3c93ad4...44ba0c7 2021-05-11 [email protected] Formatting cleanup for CONTRIBUTING.md (flutter/engine#26080) 2021-05-11 [email protected] Add uwptool.exe (flutter/engine#26038) 2021-05-11 [email protected] Manual SDK roll for DevTools SDK integration (flutter/engine#26075) 2021-05-11 [email protected] Roll Skia from 96bc12d19b9e to 7c328b4b42c5 (5 revisions) (flutter/engine#26071) 2021-05-11 [email protected] Unique frame number for each frame (flutter/engine#26021) In flutter/engine#26075 we rolled the Dart SDK to the engine. This included updates to parameter names to Iterable.map and Iterable.expand which triggers lints about renaming method parameters in CachingIterable.map and CachingIterable.expand.
bkonyi
approved these changes
May 12, 2021
jason-simmons
approved these changes
May 12, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/engine@3c93ad4...44ba0c7
2021-05-11 [email protected] Formatting cleanup for CONTRIBUTING.md (flutter/engine#26080)
2021-05-11 [email protected] Add uwptool.exe (flutter/engine#26038)
2021-05-11 [email protected] Manual SDK roll for DevTools SDK integration (flutter/engine#26075)
2021-05-11 [email protected] Roll Skia from 96bc12d19b9e to 7c328b4b42c5 (5 revisions) (flutter/engine#26071)
2021-05-11 [email protected] Unique frame number for each frame (flutter/engine#26021)
In flutter/engine#26075 we rolled the Dart SDK
to the engine. This included updates to parameter names to Iterable.map
and Iterable.expand which triggers lints about renaming method
parameters in CachingIterable.map and CachingIterable.expand.
Fixes #82260
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.