Skip to content

update the backwardsCompatibility to docs#82344

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
Abhishek01039:app_bar_theme_docs
May 14, 2021
Merged

update the backwardsCompatibility to docs#82344
fluttergithubbot merged 5 commits intoflutter:masterfrom
Abhishek01039:app_bar_theme_docs

Conversation

@Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented May 12, 2021 •
edited
Loading

Fixes #81675

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 12, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label May 12, 2021
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented May 12, 2021

Hello @HansMuller
can you please review this PR?
Thanks

HansMuller
HansMuller reviewed May 12, 2021
View reviewed changes
@Abhishek01039 Abhishek01039 requested a review from HansMuller May 12, 2021 16:58
HansMuller
HansMuller reviewed May 12, 2021
View reviewed changes
@Abhishek01039 Abhishek01039 requested a review from HansMuller May 13, 2021 02:28
HansMuller
HansMuller approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will land this after Ian gives it a no-tests exemption.

@Hixie
Copy link
Contributor

Hixie commented May 13, 2021

test-exempt: only affects comments

@fluttergithubbot fluttergithubbot merged commit 159bb94 into flutter:master May 14, 2021
@Abhishek01039 Abhishek01039 deleted the app_bar_theme_docs branch May 14, 2021 06:13
@Charly6596 Charly6596 mentioned this pull request Jul 8, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AppBarTheme titleTextStyle is not work

4 participants

@Abhishek01039 @Hixie @HansMuller @fluttergithubbot