Skip to content

Revert "Migrate to ChannelBuffers.push"#82525

Merged
fluttergithubbot merged 1 commit intomasterfrom
revert-82057-channel_buffers_5
May 14, 2021
Merged

Revert "Migrate to ChannelBuffers.push"#82525
fluttergithubbot merged 1 commit intomasterfrom
revert-82057-channel_buffers_5

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented May 14, 2021

Reverts #82057

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 14, 2021
@google-cla google-cla bot added the cla: yes label May 14, 2021
stuartmorgan-g
stuartmorgan-g approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😢

@Hixie
Copy link
Contributor Author

Hixie commented May 14, 2021

Reverted because of google3 failures and issues with the Link plugin.

@fluttergithubbot fluttergithubbot merged commit 2ae1e39 into master May 14, 2021
@fluttergithubbot fluttergithubbot deleted the revert-82057-channel_buffers_5 branch May 14, 2021 19:09
Hixie added a commit to Hixie/flutter that referenced this pull request May 14, 2021
@Hixie
Migrate to ChannelBuffers.push
f536a68 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
@Hixie Hixie mentioned this pull request May 14, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 21, 2021
@Hixie
Migrate to ChannelBuffers.push
a87a5f5 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @stuartmorgan-g @fluttergithubbot