Devicelab: removed unawaited where deemed necessary#82839
Merged
gaaclarke merged 1 commit intoflutter:masterfrom Jun 24, 2021
Merged
Devicelab: removed unawaited where deemed necessary#82839gaaclarke merged 1 commit intoflutter:masterfrom
gaaclarke merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
8 tasks
gaaclarke
force-pushed
the
unawaited-awaited
branch
from
86d3aa3 to
2fd153a
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
Ugh, I thought this merged. I'll check it out tomorrow. |
gaaclarke
force-pushed
the
unawaited-awaited
branch
from
2fd153a to
256f5ea
Compare
|
Gold has detected about 1 new digest(s) on patchset 2. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
unawaitedusage in certain cases when introduced in #82833Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.