add AnimatedScale and AnimatedRotation widgets#83428
add AnimatedScale and AnimatedRotation widgets#83428fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
There was a problem hiding this comment.
we should probably also verify that the widget itself didn't change (i.e. that we're not rebuilding the AnimatedRotation).
also we should probably verify that the rotation is having an effect (e.g. by using the transformation matrix logic to convert a point from global coordinates to the child's coordinates).
There was a problem hiding this comment.
I wasn't sure how to reach in and verify that the AnimatedScale and AnimatedRotation widgets themselves (or their implicitly associated AnimatedState objects) were being rebuilt so I added the next best thing which is to ensure that the test harness State object that encloses them is not rebuilt. I also upgraded other tests in the same file to use the same mechanism.
With respect to verifying the actual rotation/scale of the child, since the tests verify that there is a FooTransition object underneath them and that said FooTransition object has been updated with the correct scale/rotation, wouldn't the testing that the transform is really being applied fall to the FooTransition widget tests?
There was a problem hiding this comment.
@Hixie are the new mechanisms sufficient to test your concerns?
Piinks
added
a: animation
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flar
force-pushed
the
add-AnimatedScale-AnimatedRotation
branch
from
a0d9596 to
f437461
Compare
|
@flar |
|
@emvaized you should file a Github issue with that GIST. |
6 participants
The need for these 2 widgets was discovered/expressed during the implementation of #76742
This is the follow-on PR to implement these 2 simple widgets to plug a gap in the animated transitions API.
Fixes: #77081
Fixes: #65183