Support for keyboard navigation of Autocomplete options.#83696
Merged
darrenaustin merged 3 commits intoflutter:masterfrom Jun 2, 2021
darrenaustin:autocomplete_keyboard
Merged
Support for keyboard navigation of Autocomplete options.#83696darrenaustin merged 3 commits intoflutter:masterfrom darrenaustin:autocomplete_keyboard
darrenaustin merged 3 commits intoflutter:masterfrom
darrenaustin:autocomplete_keyboard
Conversation
HansMuller
approved these changes
Jun 2, 2021
Contributor
There was a problem hiding this comment.
That's attention to detail :-)
Contributor
Author
There was a problem hiding this comment.
That's an IDE that points out typos and an OCD engineer... 😄
gspencergoog
approved these changes
Jun 2, 2021
…sing the existing text editing intents.
8 tasks
Contributor
|
@darrenaustin Thanks for doing this while I was out, looks great! This is exactly how I was hoping we could do this with Actions and Shortcuts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds support for keyboard navigation to the Autocomplete widget:
Specifically it adds new intents
AutocompletePreviousOptionIntentandAutocompleteNextOptionIntentbound to the up arrow and down arrow keys respectively. These are handled by actions that move a highlight up and down the options list. If the field is submitted (usually with the enter key) it will replace the text with the highlighted option.If the app provides a custom
optionsViewBuilderto theAutocompletewidget, it will need to manage the display of the highlighted option manually. To do this they can get the index of the highlighted option with the inherited widgetAutocompleteHighlightedOption. This can be accessed in the builder with:Fixes: #82783
I have added several tests to verify the keyboard navigation is working correctly.
Pre-launch Checklist
///).