Skip to content

Clean up the bindings APIs#83843

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
Hixie:binding2
Jul 13, 2021
Merged

Clean up the bindings APIs#83843
fluttergithubbot merged 3 commits intoflutter:masterfrom
Hixie:binding2

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jun 3, 2021 •
edited
Loading

  • Add more documentation.
  • Make premature binding accesses have better runtime errors.
  • Make accesses to instance not required !.
  • Rationalize our "ensureInitialized" etc logic.

Fixes #64830.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@Hixie Hixie force-pushed the binding2 branch 3 times, most recently from 7642ff3 to 998ecbe Compare June 3, 2021 00:23
@Hixie
Copy link
Contributor Author

Hixie commented Jun 3, 2021

This will be significantly easier to review one comment at a time.

The dart fix --apply comment contains fixes either from running dart fix or from manually but mechanically fixing analyzer messages, there should be nothing controversial there.

@Hixie Hixie force-pushed the binding2 branch 6 times, most recently from 35d5d26 to ef1d4f3 Compare June 3, 2021 20:40
@Hixie
Copy link
Contributor Author

Hixie commented Jun 4, 2021 •
edited
Loading

Blocked on flutter/tests#111

@Hixie Hixie force-pushed the binding2 branch 3 times, most recently from fe330ca to fec2be2 Compare June 4, 2021 08:33
@Hixie
Copy link
Contributor Author

Hixie commented Jun 4, 2021 •
edited
Loading

Blocked on dart-lang/sdk#46264 which blocks adding // ignores to the relevant parts of the plugin repo. (Or rather, makes them ineffective.)

@skia-gold

This comment has been minimized.

Sign in to view
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 2, 2021
@fluttergithubbot fluttergithubbot merged commit e2490f2 into flutter:master Jul 13, 2021
Hixie added a commit that referenced this pull request Jul 13, 2021
@Hixie
Revert "Clean up the bindings APIs (#83843)"
2cd45a9 
This reverts commit e2490f2.
@Hixie Hixie mentioned this pull request Jul 13, 2021
Merged
Hixie added a commit that referenced this pull request Jul 13, 2021
@Hixie
Revert "Clean up the bindings APIs (#83843)" (#86386)
c800b9c 
This reverts commit e2490f2.
@Hixie Hixie deleted the binding2 branch July 13, 2021 23:07
This was referenced Jul 13, 2021
Merged
Merged
@Hixie Hixie mentioned this pull request Oct 8, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@Merdeeb-gif Merdeeb-gif Merdeeb-gif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up Binding.instance

5 participants

@Hixie @skia-gold @goderbauer @Merdeeb-gif @fluttergithubbot