It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot I signed it!

Hello @Hardeepsingh980

Thanks for this PR. This change requires tests to make sure it does not break in the future.

Hi Could you please help me write them as i have no experience writings tests in flutter. Also i looked into TextField test, test for keyboardType are also missing from their. https://github.com/flutter/flutter/blob/master/packages/flutter/test/cupertino/text_field_test.dart. There are no tests for keyboardType.

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hardeepsingh980 Is this a PR you are still interested in working on?

Hey @justinmc , I have made the changes you suggested.

Hey what’s the status on that? Seems long pending. 😞

Hey @appinteractive , I have made all the changes, according to the reviewers and still this isn't merged, no idea why?

@Hardeepsingh980 Seems like some tests are failing aren't they?

@justinmc could you assist or give a hint what needs to be done!?

@Hardeepsingh980 Thanks for the contribution! It looks like some tests are failing. If you would like to land this PR we'll need to make sure the tests pass first. If you need some help you can try asking in #hackers-new on our Discord (see the contributing guidelines below for a link to the Discord server).

@Hardeepsingh980 Let us know if you're interested in fixing the test failures (you can ping me, Hixie, on our Discord, if you need help). Otherwise we can close this PR for now and leave a comment on the relevant issue for the next person to take it over. Thanks in advance!

@pedromassango can you please have a look.

@pedromassango @justinmc if everything looks good, can we please merge this PR?

Looks like Justin’s comment was not addressed

@mrbirb Thanks for noticing that and for opening a PR to address it.

My bad. Was it addressed already? 🙈