Re-land "Migrate android_semantics_testing to null safety (#84136)"#84156
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Jun 7, 2021
Merged
Re-land "Migrate android_semantics_testing to null safety (#84136)"#84156fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
…tter#84136)" (flutter#84154)" This reverts commit 094a75e.
flutter-dashboard
bot
added
a: accessibility
darrenaustin
approved these changes
Jun 7, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
I just looked at the changes from the previous PR. LGTM.
goderbauer
changed the title
27 tasks
darrenaustin
added a commit
that referenced
this pull request
Jun 8, 2021
darrenaustin
added a commit
that referenced
this pull request
Jun 8, 2021
Piinks
added
a: null-safety
This was referenced Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #84154
Unfortunately, I wasn't able to reproduce the failure locally. I suspect it's a race condition and added a
waitForto the test to hopefully avoid it (see second commit with changes over original PR).