Re-add liblzma as an explicit dependancy on Linux#84710
Closed
MarcusTomlinson wants to merge 2 commits intoflutter:masterfrom
Closed
Re-add liblzma as an explicit dependancy on Linux#84710MarcusTomlinson wants to merge 2 commits intoflutter:masterfrom
MarcusTomlinson wants to merge 2 commits intoflutter:masterfrom
Conversation
This was referenced Jun 16, 2021
Contributor
If this issue only happens with the snap, then doesn't that mean that reverting it was correct? It's not clear to me what makes this different. Do we have a direct include of this somewhere? |
Contributor
Author
I'm so sorry! You're right, this is only snap-specific. I got misled yesterday by errors from a crusty Thank you for being thorough as always @stuartmorgan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(NOTE: This was fixed before, but was incorrectly reverted in #78415)
Description
If this library is missing, builds fail with:
//lib64/liblzma.so.5: undefined reference to 'pthread_sigmask@GLIBC_2.32'NOTE: Some distros have this library installed by default (such as Ubuntu), and some do not (such as Fedora 33+).
Related Issues
Resolves: canonical/flutter-snap#17
Tests
I've updated the relative flutter-doctor tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.