Fixed mouse cursor of disabled IconButton#84946
Merged
HansMuller merged 3 commits intoflutter:masterfrom Aug 10, 2021
Merged
Conversation
flutter-dashboard
bot
added
f: material design
HansMuller
reviewed
Aug 4, 2021
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Looks good, just need to update the API doc
Contributor
There was a problem hiding this comment.
Now the default depends on onPressed
Member
Author
There was a problem hiding this comment.
Will this work?
/// {@macro flutter.material.RawMaterialButton.mouseCursor}
///
/// If set to null, will default to
/// - [SystemMouseCursors.forbidden], if [onPressed] is null
/// - [SystemMouseCursors.click], otherwise
final MouseCursor? mouseCursor;
werainkhatri
force-pushed
the
iconbutton-cursor
branch
from
45376d2 to
f57ffff
Compare
|
Gold has detected about 17 new digest(s) on patchset 3. |
HansMuller
approved these changes
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled
IconButtonshould haveforbiddenmouse cursor instead ofclick.Current Behavior:
Proposed / Updated Behavior:
fixes #63885
Pre-launch Checklist
///).