Check for either ios-x86_64-simulator or ios-arm64_x86_64-simulator in module test#85051
Merged
jmagman merged 2 commits intoflutter:masterfrom Jun 22, 2021
Merged
Check for either ios-x86_64-simulator or ios-arm64_x86_64-simulator in module test#85051jmagman merged 2 commits intoflutter:masterfrom
jmagman merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
gw280
approved these changes
Jun 22, 2021
| )); | ||
| ); | ||
|
|
||
| final bool x86SimulatorBinaryExists = exists(File(path.join(x86SimulatorFramework, 'Flutter'))); |
Contributor
There was a problem hiding this comment.
very minor nit: x86_64 should be shortened to x64, not x86. This looks good though.
Member
Author
There was a problem hiding this comment.
I'm going to delete this code within the next few days once we validate #85045 and are confident the roll won't be reverted. Noted for future reference though.
Member
Author
|
|
Member
Author
|
This test also successfully passed on the engine roll https://ci.chromium.org/p/flutter/builders/try/Mac%20build_ios_framework_module_test/7959? |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for engine roll #85045 with recipe change https://flutter-review.googlesource.com/c/recipes/+/14780 that contains
ios-arm64_x86_64-simulatorinstead ofios-x86_64-simulatorPassing: https://ci.chromium.org/p/flutter/builders/try/Mac%20build_ios_framework_module_test/7958?