Check ios-arm64_armv7 directory when validating codesigning entitlements#85053
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jun 23, 2021
Merged
Check ios-arm64_armv7 directory when validating codesigning entitlements#85053fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
jmagman
added
c: contributor-productivity
flutter-dashboard
bot
added
the
tool
jmagman
commented
Jun 22, 2021
| fileSystem | ||
| .directory(xcframeworkPath) | ||
| .childDirectory('ios-armv7_arm64') | ||
| .childDirectory('ios-arm64_armv7') |
Member
Author
There was a problem hiding this comment.
The changes to this file aren't strictly related to the codesign issue, but may as well change them together.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine builder was updated from Xcode 11 to Xcode 12 in https://github.com/flutter/infra/pull/473. Xcode 11 generated xcframeworks as
ios_armv7_arm64but Xcode 12 switched the order toios-arm64_armv7.Update the codesign script to check for Xcode 12 naming. Will be needed for the next release after the first engine roll built with Xcode 12 #85052.
A similar change made awhile ago:
flutter/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
Lines 116 to 118 in 3ee1d46