Migrate dev/benchmarks/macrobenchmarks to null safety.#85501
Merged
darrenaustin merged 1 commit intoflutter:masterfrom Jun 29, 2021
darrenaustin:macrobenchmarks_null
Merged
Migrate dev/benchmarks/macrobenchmarks to null safety.#85501darrenaustin merged 1 commit intoflutter:masterfrom darrenaustin:macrobenchmarks_null
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:macrobenchmarks_null
Conversation
flutter-dashboard
bot
added
f: material design
27 tasks
shihaohong
reviewed
Jun 29, 2021
Contributor
shihaohong
left a comment
shihaohong
left a comment
There was a problem hiding this comment.
Everything look good, I just had a quick question about one variable that might be non-nullable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #84014