[flutter_tools] revert change to SETLOCAL ENABLEDELAYEDEXPANSION#86000
[flutter_tools] revert change to SETLOCAL ENABLEDELAYEDEXPANSION#86000jonahwilliams merged 5 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
| Directory tempDir; | ||
|
|
||
| setUp(() { | ||
| tempDir = createResolvedTempDirectorySync('exit_code_test.'); |
There was a problem hiding this comment.
Does this need to be flutter_exit_code_test. or is the flutter_ added by createResolvedTempDirectorySync?
There was a problem hiding this comment.
| ]); | ||
| expect(result.stdout, contains('args: ["(?!Golden).+"]')); | ||
| }, skip: !platform.isWindows); | ||
| }, skip: 'Reverted in https://github.com/flutter/flutter/pull/86000'); |
There was a problem hiding this comment.
Huh. I didn't know this could be a string. Does this just act like true, then?
There was a problem hiding this comment.
Yup, but I think it will display in the test output
|
Gold has detected about 2 new digest(s) on patchset 5. |
|
The customer tests : customer_testing-linux shard seems to be stuck in a bad git state. In theory this change shouldn't effect it so i'm going to land and worry about that later |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Landing to prevent more breakages from creeping in the tree |
3 participants
Revert #85288 , because it changes how error codes are propagated.
Adds a test that proves that exit codes are roughly correct ( oh boy why didn't we have this one before)
Fixes #85989