Reattempt: Restores surface size and view configuration in the postTest of test binding#87297
Merged
dkwingsmt merged 1 commit intoflutter:masterfrom Aug 11, 2021
Merged
Conversation
8 tasks
goderbauer
approved these changes
Aug 3, 2021
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
(Probably needs a rebase to make the check happy)
…flutter#87240)" (flutter#87258)" This reverts commit ccf6f03. New impl Remove temp Format
42b50fa to
f9a0be8
Compare
dkwingsmt
added a commit
that referenced
this pull request
Aug 16, 2021
dkwingsmt
added a commit
that referenced
this pull request
Aug 16, 2021
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
… binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293) This reverts commit 91f8b6b.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Sep 8, 2021
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
Closed
8 tasks
Closed
8 tasks
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jul 20, 2022
… of test binding (flutter#87240)" (flutter#87258)" (flutter#87297)" (flutter#88293)" This reverts commit 31d0787.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reattempt to fix #87194.
The previous attempt #87240 was reverted because many internal tests was written in a way that sets the view configuration at the beginning of a file and expect to use it throughout the file, which was broken by the previous method.
This PR restores the surface size and the view configuration in the following strategy:
postTest, since the surface size can not be changed out of tests.reset(the pre-test hook), and is restored to that value atpostTest.I tested this change against some previously failing tests and they have been passing.
This PR also removes the temporary teardown cleanup in
viewport_test.dart.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.