Skip to content

Exclude arm64 from iOS app archs if unsupported by plugins on x64 Macs#87362

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
jmagman:exclude-arm
Jul 30, 2021
Merged

Exclude arm64 from iOS app archs if unsupported by plugins on x64 Macs#87362
fluttergithubbot merged 2 commits intoflutter:masterfrom
jmagman:exclude-arm

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 30, 2021 •
edited
Loading

Always exclude arm64 iOS simulators when plugins don't support it, even when the host is running on an x64 Mac. This supports the ONLY_ACTIVE_ARCH=NO case where all supported simulator architectures are built.

I still see the linker error on plugins CI on top of #85713 and flutter/plugins#4208 (I was never able to reproduce this locally).

https://cirrus-ci.com/task/4907287669112832?logs=xcode_analyze#L1137-L1138

ld: in /var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/google_sign_in/google_sign_in/example/ios/Pods/GoogleSignIn/Frameworks/GoogleSignIn.framework/GoogleSignIn(GIDEMMErrorHandler_3a47e13d8ca81b41e9cdb7ef5468004a.o), building for iOS Simulator, but linking in object file built for iOS, file '/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/google_sign_in/google_sign_in/example/ios/Pods/GoogleSignIn/Frameworks/GoogleSignIn.framework/GoogleSignIn' for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Jul 30, 2021
@jmagman jmagman self-assigned this Jul 30, 2021
@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@jmagman jmagman requested a review from stuartmorgan-g July 30, 2021 18:31
@jmagman jmagman mentioned this pull request Jul 30, 2021
Merged
11 tasks
stuartmorgan-g
stuartmorgan-g approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Jul 30, 2021
Merged
11 tasks
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jul 30, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 7424db4 into flutter:master Jul 30, 2021
@jmagman jmagman deleted the exclude-arm branch July 30, 2021 21:56
@zanderso zanderso mentioned this pull request Aug 10, 2021
Closed
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
@jmagman jmagman mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

@jmagman jmagman

Labels

platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @fluttergithubbot @stuartmorgan-g