Add a doctor check for host executable compatibility#8798
Merged
johnmccutchan merged 1 commit intoflutter:masterfrom Mar 15, 2017
johnmccutchan:check_host_executables_doctor
Merged
Add a doctor check for host executable compatibility#8798johnmccutchan merged 1 commit intoflutter:masterfrom johnmccutchan:check_host_executables_doctor
johnmccutchan merged 1 commit intoflutter:masterfrom
johnmccutchan:check_host_executables_doctor
Conversation
tvolkert
approved these changes
Mar 15, 2017
Contributor
There was a problem hiding this comment.
kExpectedExitCodewith a comment on what it means? "Error" kinda makes it sound like if we see this exit code, we should return false...
Contributor
Author
There was a problem hiding this comment.
Done. I had taken the name directly from the gen_snapshot source code but I think your name is better.
Contributor
|
Travis isn't happy... |
Contributor
Author
|
@tvolkert PTAL |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6207
@mit-mit @tvolkert