Merged
Conversation
Contributor
There was a problem hiding this comment.
This should have more detail since the definition of FractionalOffset probably can't help.
Contributor
There was a problem hiding this comment.
(same comment for other classes with this field)
Contributor
|
We sure have an abundance of image-related widgets. |
Contributor
|
LGTM |
Contributor
Author
Yes. Now that we have ImageProvider, I bet we could merge RawImageResource and AsyncImage. Then we could layer AssetImage and NetworkImage on top of AsyncImage. |
- Adds dartdoc for all the `of` functions. - Renames Image to RawImage. This widget is rarely used and shouldn't take up such a nice global name. Fixes flutter#361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offunctions.such a nice global name.
Fixes #361