PopupMenu: add themeable mouse cursor#88590
Conversation
flutter-dashboard
bot
added
f: material design
jpnurmi
force-pushed
the
popup-menu-theme-mouse-cursor
branch
from
1456a62 to
f1951a9
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// | ||
| /// If this property is null, [MaterialStateMouseCursor.clickable] will be used. | ||
| /// If null, then the value of [PopupMenuThemeData.mouseCursor] is used. If | ||
| /// that is also null, then [MaterialStateMouseCursor.clickable] is used. |
There was a problem hiding this comment.
Even though it's implicitly mentioned above, it would be helpful to include a "see also" section that points at MaterialStateMouseCursor
| if (!widget.enabled) MaterialState.disabled, | ||
| }, | ||
| ); | ||
| final Set<MaterialState> states = <MaterialState>{ |
There was a problem hiding this comment.
InkWell already resolves the mouseCursor against focused/hovered/pressed/disabled and uses MaterialStateMouseCursor.clickable when mouseCursor is null. It looks like the right thing to do here is to just pass the mouse cursor along.
|
I'm closing this PR in favor of #96567 which is an updated version of the same changes. |
2 participants
Allow themes to override PopupMenu's mouse cursor.
Partial fix to #88371
Pre-launch Checklist
///).