Skip to content

Clean up the bindings APIs.#89451

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:binding5
Feb 3, 2022
Merged

Clean up the bindings APIs.#89451
fluttergithubbot merged 1 commit intoflutter:masterfrom
Hixie:binding5

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Sep 3, 2021

  • Add more documentation.
  • Make premature binding accesses have better runtime errors.
  • Make accesses to instance not required !.
  • Rationalize our "ensureInitialized" etc logic.

Fixes #64830
Fixes #78028

Most of these changes were done using dart fix --apply, but they have been squashed into one commit for easier merging.
To see previous reviews of this PR, see
#83843,
#86388,
#86438, and
#89451.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Sep 3, 2021
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 3, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Sep 13, 2021

This is blocked on finding a way to migrate Google's code.

@Hixie Hixie force-pushed the binding5 branch 5 times, most recently from d66c561 to 3ccba03 Compare September 16, 2021 23:43
@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ documentation f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. f: integration_test The flutter/packages/integration_test plugin c: tech-debt Technical debt, code quality, testing, etc. labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore error message explaining the need to call WidgetsFlutterBinding.ensureInitialized() Clean up Binding.instance

5 participants