Enable caching of CPU samples collected at application startup#89600
Merged
fluttergithubbot merged 2 commits intomasterfrom Sep 9, 2021
Merged
Enable caching of CPU samples collected at application startup#89600fluttergithubbot merged 2 commits intomasterfrom
fluttergithubbot merged 2 commits intomasterfrom
Conversation
flutter-dashboard
bot
added
the
tool
kenzieschmoll
approved these changes
Sep 7, 2021
| enableAuthCodes: disableServiceAuthCodes != true, | ||
| ipv6: ipv6 == true, | ||
| // Enables caching of CPU samples collected during application startup. | ||
| cachedUserTags: const <String>['AppStartUp'], |
Contributor
There was a problem hiding this comment.
Is there any documentation of supported tags that we could link to?
Contributor
Author
There was a problem hiding this comment.
In theory, this works for any set UserTag, so this is something that could be exposed as a CLI option at some point so users can cache samples associated with any UserTag defined in their code. However, I think it's best to just start with this single case so we can make progress on tooling for profiling application startup times.
Contributor
There was a problem hiding this comment.
Oh, I see, so UserTags are defined in user code?
Contributor
Author
There was a problem hiding this comment.
Yup, but we're setting this particular tag in the engine and resetting to default in the framework after everything's initialized. See UserTag.
bkonyi
added a commit
that referenced
this pull request
Oct 13, 2021
bkonyi
added a commit
that referenced
this pull request
Oct 21, 2021
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
flutter#89600)" (flutter#90611) This reverts commit 58944e6.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…n startup (flutter#89600)" (flutter#90611)" (flutter#91754) This reverts commit e89a885.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
flutter#89600)" (flutter#92220) This reverts commit dc7fea8.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…n startup (flutter#89600)" (flutter#92220)" (flutter#92235) This reverts commit ba0321e.
fluttergithubbot
pushed a commit
that referenced
this pull request
Feb 19, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
flutter#89600)" (flutter#98769) This reverts commit ac3c443.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
fluttergithubbot
pushed a commit
that referenced
this pull request
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84884