Revert "Enable caching of CPU samples collected at application startup"#89704
Merged
Revert "Enable caching of CPU samples collected at application startup"#89704
Conversation
flutter-dashboard
bot
added
the
tool
Member
Author
|
Merging to green the tree. |
Contributor
|
LGTM |
Contributor
|
LGTM, thanks for reverting. |
Contributor
|
This also severely regressed time to first frame, although maybe that's because of OOMs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #89600
This caused many Android tests to time out or OOM. I was able to reproduce locally with
complex_layout_android__scroll_smoothnessand confirmed it was this PR.https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8836611845424144241/+/u/run_hot_mode_dev_cycle_linux__benchmark/test_stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8836611845870259377/+/u/run_complex_layout_android__scroll_smoothness/test_stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8836611848881226001/+/u/run_channels_integration_test_win/test_stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8836611846766817729/+/u/run_drive_perf_debug_warning/test_stdout